⚡ Bolt: [performance improvement] avoid intermediate buffer in fs.readFileSync#36
Conversation
Replaced `fs.readFileSync(path).toString()` with `fs.readFileSync(path, 'utf8')` in `@expo/cli` and `@expo/config-plugins`. This micro-optimization directly passes the encoding to the filesystem API, which avoids an intermediate `Buffer` allocation and subsequent garbage collection overhead. Added inline comments to document the performance benefit. Co-authored-by: vishnu-madhavan-git <237662584+vishnu-madhavan-git@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
💡 What
Replaced
fs.readFileSync(path).toString()withfs.readFileSync(path, 'utf8')in:packages/@expo/cli/src/utils/mergeGitIgnorePaths.tspackages/@expo/config-plugins/src/android/Package.ts🎯 Why
Calling
.toString()on the result offs.readFileSynccreates an intermediateBufferobject which is then converted to a string and immediately discarded. Passing the encoding directly as the second argument ('utf8') skips the intermediate buffer allocation, reducing memory footprint and GC pressure during heavy I/O operations (like reading config files and build scripts).📊 Impact
Slight reduction in memory usage and execution time when generating or parsing large text files during build steps or CLI operations. Avoids intermediate allocations.
🔬 Measurement
Tests were run via
yarn --cwd packages/@expo/cli testandyarn --cwd packages/@expo/config-plugins testto guarantee functionality remains identical. Code behaves the exact same way.PR created automatically by Jules for task 11365293766895863294 started by @vishnu-madhavan-git